fix(cubestore): Make projection_above_limit optimization behave deter… #9766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ministically This orders columns in plan generation based on the order they're seen instead of using hash table ordering. Note that this affects internal plan nodes and does not change the output of any correctly-running queries. This has the effect of making query behavior deterministic and reproducible when investigating other bugs in query evaluation.
ovr
reviewed
Jul 9, 2025
|
|
||
| #[derive(Default)] | ||
| struct ColumnRecorder<T: ColumnCollector> { | ||
| column_hash: HashSet<Column>, |
Member
waralexrom
approved these changes
Jul 9, 2025
waralexrom
approved these changes
Jul 9, 2025
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
cube-js#9766) * fix(cubestore): Make projection_above_limit optimization behave deterministically This orders columns in plan generation based on the order they're seen instead of using hash table ordering. Note that this affects internal plan nodes and does not change the output of any correctly-running queries. This has the effect of making query behavior deterministic and reproducible when investigating other bugs in query evaluation. * chore(cubestore): Make projection_above_limit::ColumnRecorder use IndexSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ministically
This orders columns in plan generation based on the order they're seen instead of using hash table ordering. Note that this affects internal plan nodes and does not change the output of any correctly-running queries. This has the effect of making query behavior deterministic and reproducible when investigating other bugs in query evaluation.
Check List